Fix blocks navigation menu SVG icon size.

[afercia]

Fixes #11152
Fixes #11150

Adds a missing height to the Blocks navigation menu SVG icon. Fixes the misplacement of the related menu in Internet Explorer 11. See screenshot on #11152

Also exposes the keyboard shortcut in the button tooltip.

[youknowriad]

I wonder if we should use the newly added Icon component inside the IconButton component (for consistency). Not sure what impact it would have but feels like the right thing to do/try.

[afercia]

• uses the Icon component
• exposes the keyboard shortcut in the button tooltip to fix Expose the blocks navigation menu keyboard shortcut #11150

[youknowriad]

@afercia I pushed the change I proposed which is more generic but also more impacting. So I'm not certain yet at this point.

The idea is to use Icon component as the canonical component to render our icons (used by IconButton in this case).

@jasmussen @aduth Thoughts?

This also can impact all IconButtons :) In my testing, it looks good though.

[jasmussen]

Nice PR.

There's one small issue though — the button is too tall. Compare:

For whatever reason the height attribute of the icon itself is 24, when the width is 20:

I suspect this is partially because this icon was designed on a 24x24px grid, and the remaining editor bar icons are still on the 20x20 grid. Long term more icons are likely to be on the 24x24 grid, but in this case it's a mix.

This mix is also okay, because the 24x24px icon still looks crisp while scaled down to 20x20 (matching the other icons). So in this case, the solution is to make sure both the width and height of the icon are 20, even though the viewbox remains 0 0 24 24.

[youknowriad]

The height should be fixed.

[jasmussen]

Thank you! All good from my end.

[afercia]

As long as a viewBox is applied to all the rendered <svg> icons together with proper width and height I guess it should be fine on all browsers. Sorry I don't have so much time to check in depth, thanks for the ping.

[afercia]

@youknowriad if you think it's good to go, please do feel free to merge it. I'm afraid I don't have time to dedicate today and in the next days. Thanks!