-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block List: Always show trailing inserter #11329
Conversation
Yeah, this is pretty bad for nested contexts, if you're trying to make the editor look like the front-end. Why can't the sibling inserter be shown after the last block instead? Thanks to #11018, it now opens the inserter menu directly, so it would work in all nested contexts, regardless of whether they allow a Paragraph block or not. In fact, the first version of #11018 made that change and it worked great, but due to technical issues it had to be reverted. Personally, I think this default inserter should only appear when there are no blocks in the context and the Paragraph block is not supported, e.g. an empty custom post type that doesn't allow text-related blocks or an empty block with nesting that doesn't support the Paragraph block as a child. |
Another idea I just had: only show the appenders when you have selected the context they appear in, e.g. an appender would only appear in a Column block if you had selected the Column block or one of the blocks inside the Column. (Empty Column blocks would be an exception where the appender is always shown.) The appender at the bottom of the post could always be shown, but I would prefer if it was only shown when a block at the root level of the post was selected. I prefer the sibling inserter idea I talked about in my previous comment, since it doesn't cause changes in height to constantly happen, but this idea might work as well. Actually, both could be implemented, since they don't technically conflict with each other. |
I am just throwing this in here.... |
I'd be in favor of removing it for a few reasons:
|
@youknowriad you updated the description in a way it references PR :) @aduth what's the status of this one? Who should leave their feedback? @jasmussen @kjellr and @mapk (it would be nice to have a group ping for designers involved in the project willing to participate in such discussions)? Anyone else? |
Admittedly my opening of the pull request was in large part to highlight issues we have with inconsistency in how we treat inserters. To that end, I'd certainly invite feedback from designers, but I don't think this pull request provides much value in its current form as far as something which would be merged. It probably makes more sense for discussion to continue in the original issue #10519, with this serving as some prior art for the issues associated with naively displaying the trailing inserter interface everywhere. |
Partially addresses: #10519 closes #11329
This pull request seeks to update the block list to always display a trailing inserter menu.
Status: In its current form, it is very much a stub branch to prompt discussion around the interactions. Notably: