Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cover CSS specificity #12688

Closed
wants to merge 5 commits into from
Closed

Fix Cover CSS specificity #12688

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffab55f
Fix Cover CSS specificity
m-e-h Dec 7, 2018
997dd83
Merge remote-tracking branch 'upstream/master' into fix/cover-css-spe…
m-e-h Feb 8, 2019
ebc1d24
don't change text-color of the upload-media box.
m-e-h Feb 8, 2019
661dec3
keep specificity on cover-text font-size because .editor-styles-wrapp…
m-e-h Feb 8, 2019
a00c402
remove old h2 and wp-block-cover-image references
m-e-h Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 44 additions & 42 deletions packages/block-library/src/cover/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.wp-block-cover-image,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The block used to be called "Cover Image". Do we need a deprecation handler for people who inserted the block when it was called that, and who rely in this CSS?

Keep in mind someone might have installed the plugin midways, and created a bunch of reusable blocks of this. These might break?

.wp-block-cover {
position: relative;
color: $white;
background-color: $black;
background-size: cover;
background-position: center center;
Expand All @@ -14,44 +14,10 @@

&.has-left-content {
justify-content: flex-start;

h2,
.wp-block-cover-image-text,
.wp-block-cover-text {
margin-left: 0;
text-align: left;
}
}

&.has-right-content {
justify-content: flex-end;

h2,
.wp-block-cover-image-text,
.wp-block-cover-text {
margin-right: 0;
text-align: right;
}
}

h2,
.wp-block-cover-image-text,
.wp-block-cover-text {
color: $white;
font-size: 2em;
line-height: 1.25;
z-index: 1;
margin-bottom: 0;
max-width: $content-width;
padding: $block-padding;
text-align: center;

a,
a:hover,
a:focus,
a:active {
color: $white;
}
}

&.has-parallax {
Expand All @@ -78,16 +44,23 @@
}

@for $i from 1 through 10 {
&.has-background-dim.has-background-dim-#{ $i * 10 }::before {

&.has-background-dim-#{ $i * 10 }::before {
opacity: $i * 0.1;
}
}

// Aligned cover blocks should not use our global alignment rules
&.aligncenter,
&.alignleft,
&.alignright {
display: flex;
}

// Apply max-width to floated items that have no intrinsic width
&.alignleft,
&.alignright {
max-width: $content-width / 2;
width: 100%;
}

// Using flexbox without an assigned height property breaks vertical center alignment in IE11.
Expand All @@ -103,12 +76,41 @@
content: none;
}
}
}

.wp-block-cover-text {
color: inherit;
font-size: 2em;
line-height: 1.25;
z-index: 1;
margin-bottom: 0;
max-width: $content-width;
padding: $block-padding;
text-align: center;

a,
a:hover,
a:focus,
a:active {
color: inherit;
}
}

// Aligned cover blocks should not use our global alignment rules
&.aligncenter,
&.alignleft,
&.alignright {
display: flex;
.has-left-content {

h2,
.wp-block-cover-text {
margin-left: 0;
text-align: left;
}
}

.has-right-content {

h2,
.wp-block-cover-text {
margin-right: 0;
text-align: right;
}
}

Expand Down