Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rnmobile/upload captured photo #13450

Merged
merged 7 commits into from
Jan 25, 2019

Conversation

marecar3
Copy link
Contributor

Description

This is the supporting PR for upload of captured image from camera through Gutenberg Editor

@marecar3 marecar3 added the Mobile Web Viewport sizes for mobile and tablet devices label Jan 23, 2019
@marecar3 marecar3 self-assigned this Jan 23, 2019
@SergioEstevao
Copy link
Contributor

@marecar3 Do you mind merging the latest from rnmobile/upload_media_file to this PR? Just to make sure everything is in sync with the changes I did.

Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and merge the latest version of the target branch on this. Everything is working ok so I will give it the :shipit: .

I will just add a small note here for us to consider to merge the three media calls to the bridge in a single call with a type argument: .device, .mediaLibrary, .camera.

@marecar3 marecar3 merged commit 028ab55 into rnmobile/upload_media_file Jan 25, 2019
@marecar3 marecar3 deleted the rnmobile/upload_captured_photo branch January 25, 2019 09:53
@youknowriad youknowriad added this to the 5.0 (Gutenberg) milestone Jan 25, 2019
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) and removed Mobile Web Viewport sizes for mobile and tablet devices labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants