Save package-lock.json file changes #13481
Conversation
| @@ -2427,6 +2427,7 @@ | |||
| "@babel/runtime": "^7.0.0", | |||
| "@wordpress/api-fetch": "file:packages/api-fetch", | |||
| "@wordpress/data": "file:packages/data", | |||
| "@wordpress/deprecated": "file:packages/deprecated", | |||
There was a problem hiding this comment.
This is the only line I expect. What's with all the others?
There was a problem hiding this comment.
I have no idea why they show up :(
There was a problem hiding this comment.
Trying again with node_modules removed.
There was a problem hiding this comment.
gziolo$ npm --version
6.7.0This is probably why.
There was a problem hiding this comment.
Okay, I can reproduce from master running the latest npm.
Since CI runs with the latest version, I think it's probably good to expect people to align.
Line 33 in ff9961b
Makes me wonder if we still need all the tedious processing of package-lock.json changes here:
https://github.com/WordPress/gutenberg/blob/master/bin/process-git-diff.js
There was a problem hiding this comment.
npm/npm#17722 is still opened 🤷♂️
There was a problem hiding this comment.
I don't think they use their GitHub repository anymore.
There was a problem hiding this comment.
https://npm.community/t/package-lock-json-keeps-changing-between-platforms-and-runs/1129/16 - I found it in its new place. It wasn't easy.
| @@ -2427,6 +2427,7 @@ | |||
| "@babel/runtime": "^7.0.0", | |||
| "@wordpress/api-fetch": "file:packages/api-fetch", | |||
| "@wordpress/data": "file:packages/data", | |||
| "@wordpress/deprecated": "file:packages/deprecated", | |||
There was a problem hiding this comment.
Okay, I can reproduce from master running the latest npm.
Since CI runs with the latest version, I think it's probably good to expect people to align.
Line 33 in ff9961b
Makes me wonder if we still need all the tedious processing of package-lock.json changes here:
https://github.com/WordPress/gutenberg/blob/master/bin/process-git-diff.js
…rnmobile/372-add-title-to-gutenberg-mobile * 'master' of https://github.com/WordPress/gutenberg: (56 commits) Save package-lock.json file changes (#13481) Plugin: Deprecate gutenberg_add_responsive_body_class (#13461) Add speak messages to the feature toggle component. (#13385) Plugin: Deprecate gutenberg_kses_allowedtags (#13460) Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472) Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446) Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473) Fix: Categories block: add custom classes only to wrapper (#13439) is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428) Update and Organize Contributors Guide per #12916 (#13352) Dismissible-notices: fix text overlapping icon (X) (#13371) Framework: Remove 5.0-merged REST API integrations (#13408) Plugin: Remove 5.0-merged block registration functions, integrations (#13412) Framework: Bump minimum required WP to 5.x (#13370) [Mobile] Improve keyboard hide button (#13415) Improve castError handling of non strings (#13315) Fix: File block add custom class (#13432) Consider making Fullscreen Mode effects visible only on larger screens (#13425) Update plugin version to 4.9.0 (#13436) DateTimePicker: fix prop warning for (#12933) ...
|
I've been getting the same problem. Thanks for the fix! |
Description
I see these lock file changes when doing
npm ilocally. This hopefully fixes it for others, too.