Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile]Rename ref as innerRef in PostTitle #14019

Closed
wants to merge 1 commit into from
Closed

[Mobile]Rename ref as innerRef in PostTitle #14019

wants to merge 1 commit into from

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Feb 21, 2019 •
edited
Loading

Description

We are fixing the ref as innerRef because ref is not working maybe because it is reserved or sth.

How has this been tested?

Tested with wordpress-mobile/gutenberg-mobile#622

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@pinarol pinarol added the Mobile Web Viewport sizes for mobile and tablet devices label Feb 21, 2019
@pinarol pinarol self-assigned this Feb 21, 2019
@pinarol pinarol requested a review from etoledom February 21, 2019 16:17
@pinarol pinarol closed this Feb 21, 2019
@pinarol pinarol deleted the rnmobile/rename-ref branch February 21, 2019 17:14
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) and removed Mobile Web Viewport sizes for mobile and tablet devices labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom Awaiting requested review from etoledom

Assignees

@pinarol pinarol

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinarol @gziolo