Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing reference to lodash #14516

Merged
merged 1 commit into from
Mar 20, 2019
+3 −1
Merged

Added missing reference to lodash #14516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/designers-developers/developers/block-api/block-deprecation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ E.g: a block wants to migrate a title attribute to a paragraph innerBlock.
{% ES5 %}
```js
var el = wp.element.createElement,
registerBlockType = wp.blocks.registerBlockType;
registerBlockType = wp.blocks.registerBlockType,
omit = lodash.omit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if our documentation should rely on the lodash global variable being available. It would potentially block us from one day WordPress removing lodash. Maybe a better option would be to refactor the sample code to avoid the need for omit function usage?
Any thoughts on this @gziolo, @youknowriad, @aduth?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be okay to refactor, though I also don't see Lodash going anywhere anytime soon, if ever, as it's offered as a publicly-available script handle in core.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use also lodash in another example. I will land this change as it fixes an issue. If you have some good idea how to improve it further, let’s proceed with follow-up PR.


registerBlockType( 'gutenberg/block-with-deprecated-version', {

Expand Down Expand Up @@ -232,6 +233,7 @@ registerBlockType( 'gutenberg/block-with-deprecated-version', {
{% ESNext %}
```js
const { registerBlockType } = wp.blocks;
const { omit } = lodash;

registerBlockType( 'gutenberg/block-with-deprecated-version', {

Expand Down