Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unwanted theme specific Column bottom margin #14614

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Removes unwanted theme specific Column bottom margin #14614

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3772b9c
Removes unwanted theme specific Column bottom margin
getdave Mar 25, 2019
64bd7f0
Removes unwanted whitespace in CSS
getdave Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions packages/block-library/src/columns/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
}

.wp-block-column {
margin-bottom: 1em;

getdave marked this conversation as resolved.
Show resolved Hide resolved
flex-grow: 1;

// Responsiveness: Show at most one columns on mobile.
Expand Down Expand Up @@ -44,14 +46,6 @@
}
}

// Specificity overide to ensure margin is applied
// and preserved on last child to ensure that when columns
// are aligned to bottom they are are flush with each other
.wp-block-column,
.entry-content > .wp-block-columns .wp-block-column:last-child {
margin-bottom: 1em;
}

/**
* All Columns Alignment
*/
Expand Down