Add documentation for MediaPlaceholder props. #14645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
gziolo
approved these changes
Mar 27, 2019
| @@ -27,6 +27,87 @@ const { MediaPlaceholder } = wp.editor; | |||
| } | |||
| ``` | |||
|
|
|||
| ## Props | |||
|
|
|||
| ### accept | |||
There was a problem hiding this comment.
Should it be clarified what's the difference between accept and allowedTypes, if any?
|
|
||
| ### onSelect | ||
|
|
||
| Callback called when the files are selected/uploaded, the selected media are passed as an argument. |
There was a problem hiding this comment.
the selected media are passed as an argument
In what format?
jorgefilipecosta
force-pushed
the
add/documentation-for-mediaplaceholder-props
branch
from
6fc0288 to
5065d97
Compare
jorgefilipecosta
force-pushed
the
add/documentation-for-mediaplaceholder-props
branch
from
5065d97 to
223ed23
Compare
jorgefilipecosta
deleted the
add/documentation-for-mediaplaceholder-props
branch
|
Thank you for the review @gziolo your feedback was applied before the merge. |
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just adds documentation for the MediaPlaceholder props.
I noticed during a recent change that the props were not documented.
How has this been tested?
This PR just affects the documentation.