Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Fetch: Fix error on empty OPTIONS preload data #14714

Merged
merged 1 commit into from
Mar 30, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 29, 2019

Previously: #4155 (cc @imath)

This pull request seeks to resolve an error which occurs when the API Fetch preloading middleware is initialized with an empty object. Notably, this impacts preload request tests against OPTIONS requests, which prior to these changes performed an unsafe object property access.

Testing instructions:

Ensure unit tests pass:

npm run test-unit

Verify that no errors occur when resetting preloaded data to an empty array, placing the following snippet in some PHP code (e.g. a custom mu-plugin or gutenberg/gutenberg.php).

add_filter( 'block_editor_preload_paths', '__return_empty_array' );

@aduth aduth added [Type] Bug An existing feature does not function as intended [Package] API fetch /packages/api-fetch labels Mar 29, 2019
@aduth aduth requested review from mmtr and nerrad as code owners March 29, 2019 18:57
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I verified than in master when I add the provided filter we have an error, and in this branch the error does not happen.

@youknowriad youknowriad added this to the 5.4 (Gutenberg) milestone Mar 30, 2019
@youknowriad youknowriad merged commit 8d8a285 into master Mar 30, 2019
@youknowriad youknowriad deleted the fix/data-error-empty-preload branch March 30, 2019 13:52
ellatrix added a commit that referenced this pull request Apr 4, 2019
* RichText: improve format boundary style (#14519)

* RichText: improve format boundary style

* rgb => rgba

* Paste: check plain text for gutenberg content (#14536)

* Make ClipboardButton inside a block work correctly in Safari (#7106)

* Make ClipboardButton inside a block work in Safari

* Update changelogs

* Block Editor: Update "Next" to "Unreleased" per guidelines

https://github.com/WordPress/gutenberg/blob/master/packages/README.md#maintaining-changelogs

* Input Interaction: always expand single line selection vertically (#14487)

* Input Interaction: always expand single line selection vertically

* Add e2e test

* Use MenuItem instead of IconButton (#14569)

* Remove id, infoid, label and aria-describedby from MenuItem (#14423)

* Preformatted: save line breaks as characters (#14653)

* Preformatted: save line breaks as characters

* Update e2e test

* Remove negative toolbar position rules from full-aligned blocks. (#14669)

* Fix issue with double scrollbar in Fullscreen Mode (#14677)

This PR fixes an issue where the sidebar would have two scrollbars when in fullscreen mode.

* Fix WordPress embed block resolution (#14658)

* Retry failing embeds with trailing slash (#14705)

* Fix embedding Twitter URLs with a trailing slash (Closes #12664)

* Fix race condition for WordPress URLs that end in slashes, add test

* API Fetch: Fix error on empty OPTIONS preload data (#14714)

* Input Interaction: better horizontal edge detection (#14462)

* Input Interaction: better horizontal edge detection

* Correct BR ranges

* Add e2e test

* Increase buffer for Firefox

* Clean up

* Merge isEdge logic

* Fix typo

* Address feedback

* Build docs

* Fix memize option key typo (#14750)

* RichText: unify active formats, 'selectedFormat' and 'placeholderFormat' (#14411)

* RichText: unify active formats, 'selectedFormat' and 'placeholderFormat'

* Add extra e2e test

* Only should boundary style when focused

* Update docs

* Try to trigger tests with Travis

* Restore Travis config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] API fetch /packages/api-fetch [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants