Writing Flow: allow undo of patterns with BACKSPACE and ESC #14776

ellatrix · 2019-04-02T16:52:46Z

Description

Fixes #8942.
Fixes #16649.
Fixes #17038.

Sets a flag when an automatic change (input rule) happened, so it can be used to undo when Backspace, Delete or Escape is pressed. The flag is removed as soon any action follows.

This will hopefully alleviate the frustration when something automatically changes based on an input rule. It doesn't restore the selection though, only the content. For that, we'll need #16428.

How has this been tested?

See e2e tests.

Screenshots

Types of changes

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.

draganescu · 2019-04-03T10:47:57Z

Hi @ellatrix I have tested the branch and it worked but it behaved in a strange way:

When the Undo is applied the focus is lost and I can't continue typing.

ellatrix · 2019-04-03T11:54:55Z

@draganescu That's "normal". We don't have the ability yet to restore selection after undo, for that we'll need #14640. :) To test: try to undo anything in the editor, like typing a word, and you'll see that selection will be lost.

Thanks for reviewing!

draganescu

@ellatrix you are correct, that is the "normal" behavior, which makes this change set good to go. There are some conflicts though, but that it all

mapk · 2019-07-24T00:48:59Z

I'm really hoping this is the solution for #16649, but it appears there are some conflicts. Can this get rebased? I'd love to test against #16649.

ellatrix · 2019-07-24T09:23:25Z

Last time I checked I ran into some issues. I'll have to look into this again.

…SPACE and ESC

ellatrix · 2019-08-22T07:47:35Z

When the Undo is applied the focus is lost and I can't continue typing.

For that we'll need #16428, which is ready for final review.

mapk · 2019-08-23T19:23:03Z

🎉 😄

…s#14776) * RichText/Patterns/Input Interaction: allow undo of patterns with BACKSPACE and ESC * Only run input rules when inserting text * Fix typo * Simplify

mcsf · 2019-08-27T08:58:24Z

packages/block-editor/src/components/rich-text/index.js

+	 * ensure all selection changes have been recorded.
+	 */
+	markAutomaticChange() {
+		window.requestIdleCallback( () => {


Do we polyfill requestIdleCallback? It doesn't seem ready for primetime. Elsewhere in the codebase we have a fallback for it:

gutenberg/packages/priority-queue/src/index.js

Line 1 in 9c58193

const requestIdleCallback = window.requestIdleCallback ? window.requestIdleCallback : window.requestAnimationFrame;

Addressed in #17213

* RichText/Patterns/Input Interaction: allow undo of patterns with BACKSPACE and ESC * Only run input rules when inserting text * Fix typo * Simplify

into rnmobile/add-autosave-to-mobile * 'rnmobile/master' of https://github.com/WordPress/gutenberg: (52 commits) [RNMobile] DarkMode improvements (#17309) Remove redundant bg color within button appender (#17325) Support group block on mobile (#17251) [RNMobile] Insure tapping at end of post inserts at end Recover border colors (#17269) [RNMobile] Fix dismiss keyboard button for the post title (#17260) Unify media placeholder and upload props within media-text (#17268) MediaUpload and MediaPlaceholder unify props (#17145) Add native support for the MediaText block (#16305) Activate Travis CI on rnmobile/master branch (#17229) [RNMobile] Native mobile release v1.11.0 (#17181) Apply box-sizing border-box properly to the notices components (#17066) Writing Flow: allow undo of patterns with BACKSPACE and ESC (#14776) Project automation: Rewrite actions using JavaScript (#17080) Build: remove global install of latest npm since we want to use the paired node/npm version (#17134) Writing Flow/Quote: allow splitting (#17121) Use `400` as a valid `font-weight` Add: Disabled block count in the block manager (#17103) Update video player style on mobile - Add a new gridicon play icon, from: https://github.com/Automattic/gridicons/blob/87c9fce08b4a9f184b9fb4963228757fdd4f4e74/svg-min/gridicons-play.svg - Replace the Dashicon play by this one - Update icon size and icon color - Update the overlay color [RNMobile] Hide replaceable block when adding block (#16931) ... # Conflicts: # packages/block-editor/src/components/block-list/index.native.js # packages/block-editor/src/components/inserter/index.native.js # packages/block-editor/src/components/inserter/menu.native.js # packages/block-editor/src/components/media-placeholder/index.native.js # packages/block-editor/src/components/warning/index.native.js # packages/block-library/src/code/edit.native.js # packages/block-library/src/image/edit.native.js # packages/block-library/src/missing/edit.native.js # packages/block-library/src/more/edit.native.js # packages/block-library/src/nextpage/edit.native.js # packages/block-library/src/video/edit.native.js # packages/components/src/mobile/bottom-sheet/cell.native.js # packages/components/src/mobile/bottom-sheet/index.native.js # packages/components/src/mobile/dark-mode/index.native.js # packages/components/src/mobile/html-text-input/index.native.js # packages/components/src/toolbar/toolbar-container.native.js # packages/edit-post/src/components/header/header-toolbar/index.native.js # packages/edit-post/src/components/layout/index.native.js # packages/edit-post/src/components/visual-editor/index.native.js # packages/rich-text/src/component/index.native.js

ellatrix added [Status] In Progress Tracking issues with work in progress [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] History History, undo, redo, revisions, autosave. labels Apr 2, 2019

ellatrix requested review from aduth, jorgefilipecosta and youknowriad as code owners April 2, 2019 16:52

ellatrix requested review from ajitbohra, gziolo, nerrad, ntwb and talldan as code owners April 2, 2019 18:02

ellatrix added [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... and removed [Status] In Progress Tracking issues with work in progress labels Apr 2, 2019

ellatrix mentioned this pull request Apr 2, 2019

Rich Text: Patterns transform should undo on subsequent Backspace or Esc #8942

Closed

ellatrix force-pushed the try/rich-text-pattern-undo-backspace branch 2 times, most recently from 1408408 to 02b7dc7 Compare April 3, 2019 09:15

draganescu assigned draganescu and unassigned draganescu Apr 3, 2019

ellatrix added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Apr 3, 2019

ellatrix force-pushed the try/rich-text-pattern-undo-backspace branch from 02b7dc7 to b17757a Compare April 4, 2019 07:40

draganescu approved these changes Apr 10, 2019

View reviewed changes

ellatrix force-pushed the try/rich-text-pattern-undo-backspace branch from b17757a to 72da05d Compare April 12, 2019 12:11

ellatrix added the [Type] Bug An existing feature does not function as intended label Apr 12, 2019

ellatrix force-pushed the try/rich-text-pattern-undo-backspace branch from 72da05d to f0d654a Compare April 24, 2019 11:49

ellatrix added the [Status] In Progress Tracking issues with work in progress label Apr 24, 2019

ellatrix mentioned this pull request Jul 18, 2019

Adding a > to the beginning of a line forces a conversion to a Quote block #16649

Closed

ellatrix force-pushed the try/rich-text-pattern-undo-backspace branch from f0d654a to 3a06020 Compare August 21, 2019 19:11

ellatrix requested review from daniloercoli, etoledom and SergioEstevao as code owners August 21, 2019 19:11

ellatrix force-pushed the try/rich-text-pattern-undo-backspace branch from 3a06020 to f4019b0 Compare August 21, 2019 19:34

ellatrix requested review from chrisvanpatten and mkaz as code owners August 21, 2019 19:34

ellatrix removed the [Status] In Progress Tracking issues with work in progress label Aug 21, 2019

ellatrix added 4 commits August 22, 2019 09:12

RichText/Patterns/Input Interaction: allow undo of patterns with BACK…

2ba3013

…SPACE and ESC

Only run input rules when inserting text

c444e32

Fix typo

f425382

Simplify

5cfbb51

ellatrix force-pushed the try/rich-text-pattern-undo-backspace branch from be27d13 to 5cfbb51 Compare August 22, 2019 07:12

ellatrix changed the title ~~RichText/Patterns/Input Interaction: allow undo of patterns with BACKSPACE and ESC~~ Writing Flow: allow undo of patterns with BACKSPACE and ESC Aug 22, 2019

ellatrix merged commit 6ecff18 into master Aug 22, 2019

ellatrix deleted the try/rich-text-pattern-undo-backspace branch August 22, 2019 07:47

ellatrix added this to the Gutenberg 6.4 milestone Aug 22, 2019

mcsf reviewed Aug 27, 2019

View reviewed changes

mcsf mentioned this pull request Aug 27, 2019

RichText: Fall back to setTimeout if no requestIdleCallback #17213

Merged

5 tasks

mcsf mentioned this pull request Aug 31, 2019

Unable to prevent paragraph block auto transforms #17289

Closed

mcsf mentioned this pull request Sep 23, 2019

Option to use text link instead of auto embed. #15102

Closed

ellatrix mentioned this pull request Sep 26, 2019

RichText: run input rule on composition end #17610

Merged

5 tasks

pattonwebz mentioned this pull request Nov 14, 2019

Typing 1, followed by a dot, then space forces a list #18492

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Writing Flow: allow undo of patterns with BACKSPACE and ESC #14776

Writing Flow: allow undo of patterns with BACKSPACE and ESC #14776

ellatrix commented Apr 2, 2019 •

edited

Loading

draganescu commented Apr 3, 2019

ellatrix commented Apr 3, 2019

draganescu left a comment

mapk commented Jul 24, 2019

ellatrix commented Jul 24, 2019

ellatrix commented Aug 22, 2019

mapk commented Aug 23, 2019

mcsf Aug 27, 2019

mcsf Aug 27, 2019

Writing Flow: allow undo of patterns with BACKSPACE and ESC #14776

Writing Flow: allow undo of patterns with BACKSPACE and ESC #14776

Conversation

ellatrix commented Apr 2, 2019 • edited Loading

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

draganescu commented Apr 3, 2019

ellatrix commented Apr 3, 2019

draganescu left a comment

Choose a reason for hiding this comment

mapk commented Jul 24, 2019

ellatrix commented Jul 24, 2019

ellatrix commented Aug 22, 2019

mapk commented Aug 23, 2019

mcsf Aug 27, 2019

Choose a reason for hiding this comment

mcsf Aug 27, 2019

Choose a reason for hiding this comment

ellatrix commented Apr 2, 2019 •

edited

Loading