Testing: Skip test failures for font decoding warnings #15502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
aduth
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
|
I wanted to approve this PR but there is some new failure, it’s related to Classic editor so it might be WP 5.2 related as well. |
gziolo
approved these changes
May 8, 2019
aduth
force-pushed
the
update/e2e-skip-dashicons-font-warning
branch
from
8c14127 to
0e89d4f
Compare
aduth
added a commit
that referenced
this pull request
May 16, 2019
* Testing: Skip test failures for font decoding warnings * Testing: Fix Classic block Add Media toolbar button click
youknowriad
pushed a commit
that referenced
this pull request
May 16, 2019
* Testing: Skip test failures for font decoding warnings * Testing: Fix Classic block Add Media toolbar button click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue present in
mastercurrently causing all end-to-end tests to fail. There is a bug introduced with WordPress 5.2 which causes a console warning to be logged when loading the Dashicons font for some usage, notably radio buttons:https://core.trac.wordpress.org/ticket/47183
The end-to-end tests are configured to automatically fail if any unexpected console warnings or errors occur (#8721).
The changes here allow for these specific console warnings to be exempt from this, thus allowing the tests to pass.
Testing instructions:
Ensure end-to-end tests pass (also obvious by Travis build pass):