Remove chrome fix for dragging over iframes #15665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only support the last two major Chrome versions. The current version is 74, and a patch for this has landed upstream in chrome 72 https://bugs.chromium.org/p/chromium/issues/detail?id=737691
oandregal
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
noisysocks,
talldan and
youknowriad
as code owners
|
@jorgefilipecosta I've tested that this works the same than in current |
oandregal
added
Browser Issues
jorgefilipecosta
approved these changes
May 17, 2019
There was a problem hiding this comment.
Thank you for looking into this problem @nosolosw. The change worked great in my tests 👍
The iframes are not visible while dragging but that was already the case on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a fix for Chrome introduced at #9511
We only support the last two major Chrome versions. The current version is 74, and a patch for this has landed upstream in chrome 72.
Testing
The expected result is that the drag-and-drop operation works and it's not stuck mid-drag.