-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide margins to Latest Posts excerpts #15760
Provide margins to Latest Posts excerpts #15760
Conversation
Oh, also: It's worth noting that the styles in this PR will not be picked up in the front end today, even if the theme opts into the opinionated styles. That's because the classname for the excerpt is different between the front and back end. More details in #15758. |
Nice. First off, I wonder if #15758 should be fixed first, it feels like this one would matter more if that one lands first. And similarly if/when that happens, perhaps these styles are more appropriate in style.scss or theme.scss? |
Yep, #15758 has been merged in, so I think we're all good there. I've moved these to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm personally 👍👍 on this.
Cool, thanks. I'll merge this in for now then. 🙌 |
Addresses part of #15722.
#14627 added the option for users to display post excerpts and full content to posts within the Latest Posts block. It did not include any styles for that content. This means that excerpts will generally bump up against each other like so:
This PR adds some top and bottom margin to the excerpt to prevent this visual issue:
The style is entered into
editor.scss
so that it's visible in the editor, and to themes that opt-in to opinionated styles. If there's an appetite for it, this could alternatively be included instyle.scss
instead, so that the margin is supplied by default in all themes. I'm all for that, but figured we can have a discussion here first.