Remove usage of select editor from the block editor module #16184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
jorgefilipecosta
requested review from
aduth,
daniloercoli,
ellatrix,
SergioEstevao,
talldan and
youknowriad
as code owners
youknowriad
reviewed
Jun 14, 2019
| @@ -102,6 +109,7 @@ class EditorProvider extends Component { | |||
| __experimentalReusableBlocks: reusableBlocks, | |||
| __experimentalMediaUpload: hasUploadPermissions ? mediaUpload : undefined, | |||
| __experimentalFetchLinkSuggestions: fetchLinkSuggestions, | |||
| __experimentalCanUserUseUnfilteredHTML: canUserUseUnfilteredHTML, | |||
There was a problem hiding this comment.
Any reason you think this shhould be experimental?
Also these settings are documented in the defaults.js file of the block-editor package in addition to providing the default value.
There was a problem hiding this comment.
Hi @youknowriad the default.js file was updated, nice catch.
The setting was only marked as experimental because lately all new additions were kept experimental for one version so I followed the same logic, but I can change it.
jorgefilipecosta
force-pushed
the
refactor/remove-usage-of-select-block-editor-from-the-block-editor-module
branch
from
8c41ea2 to
5223795
Compare
jorgefilipecosta
force-pushed
the
refactor/remove-usage-of-select-block-editor-from-the-block-editor-module
branch
from
5223795 to
16c677a
Compare
ellatrix
approved these changes
Jul 10, 2019
jorgefilipecosta
deleted the
refactor/remove-usage-of-select-block-editor-from-the-block-editor-module
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The block editor performed a select to the core/editor store, this causes problems when the editor store is not available e.g. in the widget screen after we merge #16160.
This PR refactors to code to use a block editor setting instead of the editor store.
How has this been tested?
With an admin rule, I pasted the following in a paragraph:
<iframe src="httt://www.wordpress.org/" />. I verified an HTML block with the iframe was created.With a contributor rule I pasted the same code I verified an HTML block with the iframe was not created.