Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try solid block movers #16947

Closed
wants to merge 3 commits into from
Closed

Try solid block movers #16947

wants to merge 3 commits into from

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Aug 7, 2019

Closes #16580.

This PR implements the idea shared by @richtabor in #16580: it gives the block movers a solid color background, and hangs them off the side of the thick left block border.

I'm not totally sure about this yet — it makes the mover controls really prominent, and I'm not sure that's right. I think it could still use some iteration.

Hover:

Screen Shot 2019-08-07 at 2 19 56 PM

Select:

Screen Shot 2019-08-07 at 2 20 04 PM


Still todo:

  • Build in a more prominent focus state.
  • Come out with a better plan for how these work with breadcrumbs. Things look a little disjointed for standard blocks, and even worse for wide/full-aligned blocks.
  • Double check to make sure the changed $block-side-ui-width variable didn't have any unintended effects. It appears to be used in many places.

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback. labels Aug 7, 2019
@kjellr kjellr self-assigned this Aug 7, 2019
@enriquesanchez
Copy link
Contributor

While I agree this makes the mover controls more prominent, I do feel this is an improvement over what we currently have.

Perhaps we can have the hover style only on the individual icons instead of the whole movers area?

@shaunandrews
Copy link
Contributor

F6E54C89-C2B7-4C91-BD1C-09E397056E5D

The spacing around the label and the drag container is a little strange for the hover state.

@karmatosed
Copy link
Member

I personally feel this makes it a little too heavy as far as the interface goes. I think it's circling around a valid problem of visibility, just not very sure that approach is one balances it out.

@mapk
Copy link
Contributor

mapk commented Aug 20, 2019

Thanks for creating the PR, @kjellr. While I really like the connection of the mover controls to the block, and the way they are combined into one unit (not separate buttons), the heavier weight of these don't work as well in light of smaller blocks. Here's some examples that convey this:

Separator block
Screen Shot 2019-08-20 at 12 40 46 PM

Paragraph block
Screen Shot 2019-08-20 at 12 41 05 PM

I don't mind taking a break from this PR for now until the recent icon issues that have surfaced get resolved.

@kjellr
Copy link
Contributor Author

kjellr commented Aug 21, 2019

I don't mind taking a break from this PR for now until the recent icon issues that have surfaced get resolved.

Yeah, I think I'm actually going to close this for now. It doesn't seem like a viable solution in its current state. We can continue iterating on the design in #16580.

Thanks, folks!

@kjellr kjellr closed this Aug 21, 2019
@kjellr kjellr deleted the try/solid-block-movers branch August 21, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Mover: Try cleaning up the control UI
5 participants