Show Height control in Cover if we only selected an image #17371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
[Type] Bug
senadir
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
it seems this PR get staled and need a rebase |
senadir
force-pushed
the
fix/cover-show-height-control-with-image
branch
from
1f0c5fd to
c31c5f5
Compare
|
@youknowriad this has been rebased and is ready to review & merge |
youknowriad
pushed a commit
that referenced
this pull request
Sep 30, 2019
* refactor-size-control-to-its-panel * rename Size to Dimensions
youknowriad
pushed a commit
that referenced
this pull request
Sep 30, 2019
* refactor-size-control-to-its-panel * rename Size to Dimensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #17258
This PR takes the height control and put it in its own panel, it didn't make much sense to keep it with the media settings since it has nothing to do with media, since we can control the size with only the color, so a new panel "Dimensions" is here
How has this been tested?
Screenshots