Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Menu: sub menu items design #18350

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Navigation Menu: sub menu items design #18350

merged 2 commits into from
Nov 8, 2019

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Nov 6, 2019

Description

This PR tweaks the navigation menu in order to make correspond to what the front-end and the Editor canvas show. It adds the theme.scss file to the block.

How has this been tested?

Check how the menu looks on both sides.

Screenshots

image

image

Types of changes

  • Adds the theme.scss file to the navigation menu block
  • Implements very basic styles to the menu.

Related Issues

#18310

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@retrofox retrofox added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block labels Nov 6, 2019
@retrofox retrofox self-assigned this Nov 8, 2019
@karmatosed karmatosed mentioned this pull request Nov 8, 2019
Closed
@karmatosed karmatosed self-requested a review November 8, 2019 16:51
karmatosed
karmatosed approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on design and also code because CSS.

@karmatosed karmatosed merged commit 02d8931 into master Nov 8, 2019
@karmatosed karmatosed deleted the update/navigation-menu-sub-menu-items-re-design branch November 8, 2019 16:52
@karmatosed
Copy link
Member

Noting I want to merge this to work off it in another PR as had one at same time.

@retrofox
Copy link
Contributor Author

retrofox commented Nov 8, 2019

Really appreciate it since it got kind of stuck. Good to know you are going to keep improving this. 🙇

@retrofox retrofox changed the title [wip] Navigation Menu: sub menu items design Navigation Menu: sub menu items design Nov 8, 2019
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karmatosed karmatosed karmatosed approved these changes

@shaunandrews shaunandrews Awaiting requested review from shaunandrews

@getdave getdave Awaiting requested review from getdave

@mtias mtias Awaiting requested review from mtias

@frontdevde frontdevde Awaiting requested review from frontdevde

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

@retrofox retrofox

Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 6.9
Development

Successfully merging this pull request may close these issues.
3 participants
@retrofox @karmatosed @youknowriad