Fix theme background regression. #18687
Conversation
jasmussen
added
[Type] Bug
| @@ -1,3 +1,9 @@ | |||
| // This min-height is there to ensure the editing canvas extends at least to the full height available. | |||
| // This ensures a theme that uses a background color other than white doesn't look cropped without content. | |||
| .edit-post-visual-editor { | |||
There was a problem hiding this comment.
Should we move this to the stylesheet specific for that component https://github.com/WordPress/gutenberg/blob/master/packages/edit-post/src/components/visual-editor/style.scss#L1
|
It didn't occur to me that this existed, but I think I tackled the same issue in my pull request at #18732 . While the changes here are sufficient to stretch the theme background, there are also issues with clicks below the editor not directing focus to the last default block. I've included a fix for that in #18732. |
This PR fixes that.
jasmussen
force-pushed
the
fix/theme-bg-issue
branch
from
2a0ee55 to
81f9eb6
Compare
|
I rebased to see if that makes the checks pass. And then I read your comment, Andrew! Please feel free to merge yours as it seems to be a better fix than this one, and I'll close this PR. 🎉 |
|
Superseded by #18732 |
#18044 introduced a small regression where a theme with a non-white background, for example TwentyTwenty, looked cropped.
This PR fixes that by applying a min-height to the canvas.
Before:
After: