Nav Block - show recent pages as default suggestions when creating Nav Links#19458

Merged

getdave merged 29 commits intomasterfrom add/show-pages-default-when-creating-nav-links

Jan 15, 2020

+185-28

Commits on Jan 15, 2020

Adds ability to manual trigger search data fetch
getdave
committed
Update to prop to experimental and rename to initialSuggestions
getdave
committed
Query for and display 5 most recently modified Pages
getdave
committed
Update initial suggestions to be display whenever the input is empty and there are no current suggestions
getdave
committed
Fix to ensure initial suggestions are shown when pages request fulfills
getdave
committed
Updates to display 3 most recently modified pages instead of 5
getdave
committed
Fix to allow keyboard arrow to move focus into suggestions when present
getdave
committed
Fix bug whereby not providing initialSuggestions to LinkControl disabled the ability to search at all
getdave
committed
Adds tests to cover displaying initial suggestions
getdave
committed
Removes redundant const comment
getdave
committed
Test fix to e2e tests
getdave
committed
Try looser mock request matching to fix e2e test failures
getdave
committed
Try fix Travis e2e test failure by clearing request mocks
getdave
committed
Fix not awaiting mock setup
getdave
committed
Fix inadvertant revert of e2e test fix
getdave
committed
Refactor to remove seperate initialSuggestions query
getdave
committed
Refactor to use empty value as condition for initialSuggestions request
getdave
committed
Fix “suggestions” typo
getdave
committed
Update to reuse existing edit constant
getdave
committed
Fix initial suggestions showing when input has value
getdave
committed
Fix potential infinite render using flag to conditionalise updating suggestions on update or mount
getdave
committed
Add test to cover inifinite re-render loop.
getdave
committed
Fixes typo in WordPress ORG link in e2e tests
getdave
committed
Fix e2e test failure due to console warning in LinkControl
getdave
committed
Revise snapshots
getdave
committed
Restore missing fetchSearchSuggestions prop following rebase
getdave
committed
Fix lint indentation error
getdave
committed
Rename prop
getdave
committed
Fix test broken due to prop rename
getdave
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nav Block - show recent pages as default suggestions when creating Nav Links#19458

Commits on Jan 15, 2020

Adds ability to manual trigger search data fetch

Update to prop to experimental and rename to initialSuggestions

Query for and display 5 most recently modified Pages

Update initial suggestions to be display whenever the input is empty and there are no current suggestions

Fix to ensure initial suggestions are shown when pages request fulfills

Updates to display 3 most recently modified pages instead of 5

Fix to allow keyboard arrow to move focus into suggestions when present

Fix bug whereby not providing initialSuggestions to LinkControl disabled the ability to search at all

Adds tests to cover displaying initial suggestions

Removes redundant const comment

Test fix to e2e tests

Try looser mock request matching to fix e2e test failures

Try fix Travis e2e test failure by clearing request mocks

Fix not awaiting mock setup

Fix inadvertant revert of e2e test fix

Refactor to remove seperate initialSuggestions query

Refactor to use empty value as condition for initialSuggestions request

Fix “suggestions” typo

Update to reuse existing edit constant

Fix initial suggestions showing when input has value

Fix potential infinite render using flag to conditionalise updating suggestions on update or mount

Add test to cover inifinite re-render loop.

Fixes typo in WordPress ORG link in e2e tests

Fix e2e test failure due to console warning in LinkControl

Revise snapshots

Restore missing `fetchSearchSuggestions` prop following rebase

Fix lint indentation error

Rename prop

Fix test broken due to prop rename