Navigation: formatting the allowed styles

[retrofox]

Description

This PR handles rightly applying HTML format to menu items, avoiding escape HTML characters for those ones which are allowed.

Fixes #19473

How has this been tested?

You can format the menu items using the toolbar of the navigation menu. So far, it's possible to set up bold, italic, code, underline, strikethrough, span text, and inline-image.

In order to test it, just apply some format to the navigation item and confirm that the format s applied as expected in the front-end.

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code has proper inline documentation.

[WunderBart]

Tested by applying a bunch of formatting options - looks good on both front & back-end!

[getdave]

Nice work.

I tested this and all the formats appeared to apply correctly in Editor and on front end.

Frontend

Editor

[retrofox]

Thanks for reviewing, folks!

[draganescu]

@retrofox be careful with that planet destroyer!

[retrofox]

@retrofox be careful with that planet destroyer!

No kidding, he's so cute as destructive! 😱

[maheshwaghmare]

Nice work!

I was also thinking to create a PR but @retrofox did nice work.

---

Below are my findings.

Backend: https://share.getcloudapp.com/xQu0zkwJ

Before Code:

$html .= esc_html( $block['attrs']['label'] );

Before Front End : https://share.getcloudapp.com/ApuOxoe5

After Code:

$html .= wp_kses_post( $block['attrs']['label'] );

After Front End: https://share.getcloudapp.com/p9u5X4Z1

[retrofox]

Thanks, @maheshwaghmare for your comment.

After Code:

$html .= wp_kses_post( $block['attrs']['label'] );

I did a quick research about how to tackle this issue and found wp_kses_post() as well. The thing is if I'm not wrong wp_kses() fits better on this solution since it allows us to define the allowed tags and, since they are just a few, the performance will be better than using the wp_kses_post().

[obenland]

I wouldn't be too concerned about performance with strings as short as we can expect in a label

[retrofox]

I wouldn't be too concerned about performance with strings as short as we can expect in a label

So we could consider switching to wp_kses_post() since if we add a new HTML tag then we will need to update the list of wp_kses().

[obenland]

oh, my bad, yes absolutely, I think I'd prefer wp_kses_post() here as well