Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes e2e test failures via console log exception to handle temp wpnonce error #19532

Merged
merged 2 commits into from
Jan 10, 2020
+8 −0
Merged

Fixes e2e test failures via console log exception to handle temp wpnonce error #19532

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f6c4dc
Adds console log exception to handle temp wp nonce error
getdave Jan 9, 2020
fbbe547
Refactor to make test for console msg more resilient and tollerant
getdave Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/e2e-tests/config/setup-test-framework.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,14 @@ function observeConsoleLogging() {
return;
}

// As of WordPress 5.3.2 in Chrome 79, navigating to the block editor
// (Posts > Add New) will display a console warning about
// non - unique IDs.
// See: https://core.trac.wordpress.org/ticket/23165
if ( text.includes( '[DOM] Found 2 elements with non-unique id #_wpnonce' ) ) {
getdave marked this conversation as resolved.
Show resolved Hide resolved
return;
}

const logFunction = OBSERVED_CONSOLE_MESSAGE_TYPES[ type ];

// As of Puppeteer 1.6.1, `message.text()` wrongly returns an object of
Expand Down