Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Remove non-public fetchSearchSuggestions from LinkControl documentation #19710

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 16, 2020

Previously: #19705 (comment)

This pull request seeks to resolve an issue where the LinkControl component is documented to support a fetchSearchSuggestions prop. However, this prop was removed as of #19705 under the assumption it was not expected to be needed (after #19638).

That said, there's two approaches this could take:

  • Reintroduce the prop to the component
  • Remove the documented prop

The current pull request changes implement the second option.

It is not clear to me whether this prop is actually needed, or if it's sufficient to rely on the __experimentalFetchLinkSuggestions block settings value which is select-ed in the internal implementation of the component. It may have been useful previously for the purpose of the unit tests to verify the expected behavior of a stubbed fetch function.

Testing Instructions:

Currently, the only changes are to the documentation, so there are no expected changes to the application runtime.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aduth aduth merged commit 9efa957 into master Jan 17, 2020
@aduth aduth deleted the remove/link-control-fetch-search-suggestions branch January 17, 2020 15:38
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block editor /packages/block-editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants