Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Management Automation: Check error object for parsed errors #20014

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

aduth
Copy link
Member

@aduth aduth commented Feb 3, 2020

Previously: #20011

This pull request seeks to fix the check to determine whether an error thrown in the creation of the milestone during the add-milestone automation task is an error representing a duplicate entity.

Based on related resources, it should be the case that this can be determined using the parsed errors property of the error object.

@aduth aduth added [Type] Bug An existing feature does not function as intended [Type] Project Management Meta-issues related to project management of Gutenberg labels Feb 3, 2020
@aduth
Copy link
Member Author

aduth commented Feb 3, 2020

The failing build does not seem that it should be related, and is of the same sort of intermittent failure that #18773 had originally hoped to address (ZIP failure download). Since it's not related, and I don't think the E2E jobs are particularly relevant for this package, I'm going to merge anyways.

@aduth aduth merged commit 8678c59 into master Feb 3, 2020
@aduth aduth deleted the fix/milestone-parsed-errors branch February 3, 2020 20:53
@github-actions github-actions bot added this to the Gutenberg 7.5 milestone Feb 3, 2020
@aduth
Copy link
Member Author

aduth commented Feb 3, 2020

The action ran successfully this time 🎉

https://github.com/WordPress/gutenberg/runs/424037572?check_suite_focus=true

add-milestone: Fetching current milestone
add-milestone: Fetching `package.json` contents
add-milestone: Current plugin version is 7.4
add-milestone: Creating 'Gutenberg 7.5' milestone, due on 2020-01-27T00:00:00.000Z
add-milestone: Milestone already exists, proceeding with assignment
add-milestone: Fetching all milestones
add-milestone: Adding issue #20014 to milestone #114
main: All done!

You can also see in the history of this pull request that the bot assigned the milestone:

#20014 (comment)

@epiqueras
Copy link
Contributor

Nice work!

@aduth
Copy link
Member Author

aduth commented Feb 3, 2020

Thanks for the timely reviews!

The continued iterations would seem to highlight that this is worth some consideration about how to improve the workflow to changes (verifying correctness) in these automations.

@epiqueras
Copy link
Contributor

I think actions have a testing framework now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants