Add prettier dependency to @wordpress/eslint-plugin

[kasparsd]

Description

Fixes #20027.

In #19963 we added eslint-plugin-prettier as a dependency to @wordpress/eslint-plugin in f5c44ea which requires prettier as a peer dependency.

How has this been tested?

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR. .

[kasparsd]

This matches what was used in #18048 for wp-scripts in d20fa45.

[epiqueras]

You need to commit lock-file changes.

[ntwb]

I think we need to take some time to test the configuration combinations that @wordpress/scripts and @wordpress/eslint-plugin can be used.

See also 0a96d2c

Edit: Discussion is also on the agenda for todays #core-js chat in Slack shortly

[epiqueras]

How so?

[kasparsd]

You need to commit lock-file changes.

@epiqueras I'm not seeing a lock file in the root directory of this package so I wasn't sure it's required. Please confirm.

[epiqueras]

It's at the root of the repo (Lerna hoisting). Just run npm install.

[ntwb]

The lock file needs to b updated using Lerna, not npm install

See: https://github.com/WordPress/gutenberg/tree/master/packages#adding-new-dependencies

Though I'm not sure how Lerna will handle the npm alias /shrug

lerna add npm:wp-prettier packages/eslint-plugin

[epiqueras]

Both work.

[ntwb]

Let's follow the docs please @epiqueras, Lerna has idiosyncratic behaviour that lends to having the lock file out of date, the docs were written to mitigate this scenario as much as possible from past expereinces

[kasparsd]

Lock file updated in 2026a60

[gziolo]

It looks good as far as I can tell. In the lock, there is only one line updated which means the same version is shared 👍

@kasparsd, thanks for catching and proposing the fix. We didn't test ESLint plugin in isolation :)

[epiqueras]

Let's follow the docs please @epiqueras, Lerna has idiosyncratic behaviour that lends to having the lock file out of date, the docs were written to mitigate this scenario as much as possible from past expereinces

I thought we had a postinstall hook. If not, we should have one. We also need to correct that documentation to use the local version of Lerna.

Does that sound good? I can open a PR.

cc @aduth