Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock Button block for production #20093

Merged
merged 10 commits into from
Feb 14, 2020
Merged

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Feb 7, 2020

Description

Unblocking Button block for production

ref to gb-mobile: wordpress-mobile/gutenberg-mobile#1866

How has this been tested?

https://github.com/wordpress-mobile/test-cases/blob/master/test-cases/gutenberg/button.md

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested from the WordPress Android build -> wordpress-mobile/gutenberg-mobile#1866 (comment)

packages/block-library/src/button/edit.native.js Outdated Show resolved Hide resolved
packages/block-library/src/button/edit.native.js Outdated Show resolved Hide resolved
packages/block-library/src/button/edit.native.js Outdated Show resolved Hide resolved
packages/block-library/src/button/edit.native.js Outdated Show resolved Hide resolved
packages/block-library/src/button/edit.native.js Outdated Show resolved Hide resolved
@geriux
Copy link
Member

geriux commented Feb 13, 2020

Did another test after the latest changes and all is working great! LGTM!

@dratwas
Copy link
Contributor

dratwas commented Feb 14, 2020

LGTM! Good job @lukewalczak

@lukewalczak lukewalczak merged commit 95be294 into master Feb 14, 2020
@lukewalczak lukewalczak deleted the rnmobile/unblock-button branch February 14, 2020 10:06
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants