Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that all strong tags are removed from title. #20288

Closed
wants to merge 2 commits into from

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Feb 18, 2020

Description

This change makes sure that any extra strong element tags added on the post-title are removed correctly. This could have happened because of the presence of emoji characters on the title that made the RichText native element to add extra strong elements around the emojis.

How has this been tested?

This can be tested with this GB-mobile PR: wordpress-mobile/gutenberg-mobile#1930

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@SergioEstevao SergioEstevao added the [Type] Bug An existing feature does not function as intended label Feb 18, 2020
@SergioEstevao SergioEstevao added this to the Future milestone Feb 18, 2020
@SergioEstevao SergioEstevao changed the base branch from rnmobile/release-1.23.0 to master February 18, 2020 17:55
@SergioEstevao
Copy link
Contributor Author

Closing in favour of: #20291

@SergioEstevao SergioEstevao deleted the rnmobile/fix_title_with_emoji branch March 18, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants