-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Add useResizeObserver()
to Column Block
#20838
Merged
jbinda
merged 19 commits into
rnmobile/column-block
from
rnmobile/column-block-with-container-matches-hoc
Mar 16, 2020
Merged
[RNMobile] Add useResizeObserver()
to Column Block
#20838
jbinda
merged 19 commits into
rnmobile/column-block
from
rnmobile/column-block-with-container-matches-hoc
Mar 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hoc' into rnmobile/try/column-block-with-useResizeObserver
…hoc' into rnmobile/try/column-block-with-useResizeObserver
…ith-useResizeObserver
…container-matches-hoc
…container-matches-hoc
jbinda
added
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Block] Columns
Affects the Columns Block
labels
Mar 12, 2020
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
…container-matches-hoc
lukewalczak
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Columns
Affects the Columns Block
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings adjustments need to allow using
useResizeObserver()
inside Column Block.Please refer to:
useResizeObserver() PR
Column Block PR
How has this been tested?
Checking all Column Block PR testing requirements (see Column PR description)
Types of changes
New feature - Change the way how container size is measured.
Checklist: