Update the columns block to use the new colors hook #21038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -42 B (0%) Total Size: 859 kB
ℹ️ View Unchanged
|
youknowriad
changed the title
gziolo
reviewed
Mar 21, 2020
There was a problem hiding this comment.
Nice, I like the direction.
Unrelated note. The number of experimental props used for RichText and InnerBlocks makes it nearly impossible for 3rd party devs to follow code implementation uses in Gutenberg 🙁 It also means it’s all undocumented and difficult to use for contributors...
True, we need to continue our audits. the color hook is something I want to stabilize pretty quickly |
youknowriad
force-pushed
the
update/group-colors
branch
2 times, most recently
from
92ef4bb to
dfca58c
Compare
youknowriad
force-pushed
the
update/columns-colors
branch
from
0127313 to
5a2e929
Compare
youknowriad
added
[Block] Columns
youknowriad
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
This one is ready to ship. |
youknowriad
added
Needs Dev
|
Oh, it seems we might need a deprecated version here, I'll add it and ship. |
youknowriad
force-pushed
the
update/columns-colors
branch
from
07af0d0 to
5fed61c
Compare
youknowriad
commented
Mar 25, 2020
| @@ -101,7 +101,9 @@ const BlockComponent = forwardRef( | |||
| // should only consider tabbables within editable display, since it | |||
| // may be the wrapper itself or a side control which triggered the | |||
| // focus event, don't unnecessary transition to an inner tabbable. | |||
| if ( wrapper.current.contains( document.activeElement ) ) { | |||
| if ( | |||
| isInsideRootBlock( wrapper.current, document.activeElement ) | |||
There was a problem hiding this comment.
For me this is a bug that is present on master too. If you want to select a block, you want to select the root block, not an inner one.
youknowriad
commented
Mar 25, 2020
| @@ -91,7 +91,7 @@ describe( 'Navigating the block hierarchy', () => { | |||
| await pressKeyWithModifier( 'ctrl', '`' ); | |||
| await pressKeyWithModifier( 'ctrl', '`' ); | |||
| await pressKeyWithModifier( 'ctrl', '`' ); | |||
| await pressKeyTimes( 'Tab', 4 ); | |||
| await pressKeyTimes( 'Tab', 5 ); | |||
There was a problem hiding this comment.
The colors panel is shown before the columns count now.
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #21021 to try test the API on different blocks (columns for this PR)