Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default icon from PluginBlockSettingsMenuItem #21392

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Remove default icon from PluginBlockSettingsMenuItem #21392

merged 1 commit into from
Dec 9, 2020

Conversation

HardeepAsrani
Copy link
Contributor

Description

Remove default icon from PluginBlockSettingMenuItem as the new Gutenberg UI
doesn't have icons by default. Closes #21390

How has this been tested?

Tested with a plugin that uses PluginBlockSettingMenuItem with and without passing the icon.

Types of changes

Enhancement: If someone uses PluginBlockSettingMenuItem without an icon, their menu item will stop displaying the default Plugin icon.

Checklist:

  • [ x ] My code is tested.
  • [ x ] My code follows the WordPress code style.
  • [ x ] My code follows the accessibility standards.
  • [ x ] My code has proper inline documentation.
  • [ x ] I've included developer documentation if appropriate.
  • [ x ] I've updated all React Native files affected by any refactorings/renamings in this PR.

Remove default icon from PLuginBlockSettingMenuItem as new Gutenberg UI
doesn't have icons by default. Closes #21390
@gziolo gziolo added Needs Design Feedback Needs general design feedback. [Feature] Extensibility The ability to extend blocks or the editing experience [Package] Edit Post /packages/edit-post labels Apr 3, 2020
@karmatosed
Copy link
Member

From a design perspective, this feels fine for me as I can see a default could be an unexpected experience. I am going to loop in @jasmussen here though to get an opinion on how this impacts the toolbar as it might mean complications there.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label May 1, 2020
@jasmussen
Copy link
Contributor

I would agree, this seems like a good change. We should be intentional about using icons in menus. Nice work.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in, thank you 👍

@gziolo gziolo merged commit a5c3cf2 into WordPress:master Dec 9, 2020
@github-actions github-actions bot added this to the Gutenberg 9.6 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Package] Edit Post /packages/edit-post
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to remove icon in PluginBlockSettingsMenuItem
4 participants