Refactor FontSizePicker component. Fix bug on undo. #21757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Size Change: -73 B (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
|
It's an honor to have my name CCed instead of @draganescu but he opened the original issue 😄 |
|
Thank you @jorgefilipecosta I'll test and review this asap! |
draganescu
force-pushed
the
update/refactor-FontSizePicker-component-to-avoid-local-state-Fix-bug-on-undo
branch
from
b556704 to
2338b12
Compare
draganescu
approved these changes
Apr 29, 2020
|
Also found #21975 while testing this. |
jorgefilipecosta
changed the title
jorgefilipecosta
deleted the
update/refactor-FontSizePicker-component-to-avoid-local-state-Fix-bug-on-undo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #19276
This PR refactors the FontSizePicker component and totally removes local state from the component, simplifying its code.
The PR ends up fixing issue #19276 which was caused by the fact the component contained local state that was not properly updated during an undo operation.
cc: @andreilupu
How has this been tested?
I verified font size picking still works as expected.
I repeated the steps referred on #19276 and verified the issue was not happening anymore.