Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Fix <ServerSideRender> 404 link #21968

Merged
merged 2 commits into from
May 15, 2020
Merged

Conversation

huntlyc
Copy link
Contributor

@huntlyc huntlyc commented Apr 29, 2020

Description

Current component link in "live rendering in the block editor section leads to a 404. Suggest replacing it with the editor handbook page on this component?

How has this been tested?

Double checked the link!

Types of changes

Bug Fix

Current <ServerSideRender> component link in "live rendering in the block editor section leads to a 404.  Suggest replacing it with the editor handbook page on this component?
@talldan talldan changed the title Fix <ServerSideRender> 404 link Documentation: Fix <ServerSideRender> 404 link Apr 29, 2020
@Soean Soean added the [Type] Developer Documentation Documentation for developers label Apr 29, 2020
…creating-dynamic-blocks.md

Co-authored-by: Marcus Kazmierczak <[email protected]>
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍

@mkaz mkaz merged commit 904c855 into WordPress:master May 15, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 15, 2020
@github-actions
Copy link

Congratulations on your first merged pull request, @huntlyc! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 8.2 milestone May 15, 2020
@huntlyc
Copy link
Contributor Author

huntlyc commented May 15, 2020

@mkaz - thanks for your help on this and thanks for all your work on WordPress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants