Image Block: add caption field to placeholder #22295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Size Change: +1.13 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/image-placeholder-caption
branch
from
5adf663 to
9214bf4
Compare
ellatrix
force-pushed
the
try/image-placeholder-caption
branch
from
9214bf4 to
e48fec7
Compare
ellatrix
force-pushed
the
try/image-placeholder-caption
branch
from
609f29d to
4369fd9
Compare
This was referenced Jun 8, 2020
Closed
|
This behavior has been raised here as problematic #21252 (comment) It did seem a bit unexpected for me too. I'm on the fence. |
|
Why is it problematic? It seems like the question raised is whether it can be moved to the top |
|
Placeholders were added to Gutenberg so you could fill create and fill out some content while leaving other places black to fill in later. I believe this fits that vision? |
|
Can we talk about this again in the next core-editor meeting next Wednesday? |
oandregal
pushed a commit
that referenced
this pull request
Jun 9, 2020
oandregal
pushed a commit
that referenced
this pull request
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22294.
How has this been tested?
Screenshots
Types of changes
Checklist: