-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigation block placeholder overlap on Nav Menus page #22407
Merged
talldan
merged 1 commit into
master
from
fix/navigation-placeholder-overlap-on-nav-menu-page
May 18, 2020
Merged
Fix navigation block placeholder overlap on Nav Menus page #22407
talldan
merged 1 commit into
master
from
fix/navigation-placeholder-overlap-on-nav-menu-page
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
requested review from
noisysocks,
tellthemachines,
adamziel and
draganescu
May 18, 2020 06:47
talldan
added
the
CSS Styling
Related to editor and front end styles, CSS-specific issues.
label
May 18, 2020
draganescu
approved these changes
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🛸
Size Change: +50 B (0%) Total Size: 835 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CSS Styling
Related to editor and front end styles, CSS-specific issues.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The placeholder on the navigation block is overlapping its panel on the nav menus page, which this PR fixes (see screenshots).
The placeholder uses a
width: 100%
in addition to padding, which with the default ofbox-sizing: content-box
causes an overlap. Enablingbox-sizing: border-box
for elements in the nav menus page resolves the issue.How has this been tested?
Screenshots
Before
After
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: