Change inserter search placeholder text color #22444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +275 kB (24%) 🚨 Total Size: 1.11 MB
ℹ️ View Unchanged
|
|
@jasmussen if you don't mind, I would love to have your review this little PR. I couldn't find any other place in the UI where this background and foreground color combination was being used, so what I did was find the color combo that just gets us past the success ratio and added it just to this element. If this color change proposal is acceptable, I'm sure we'd want to be able to re-use it, so probably creating a variable would be best? |
jasmussen
reviewed
May 19, 2020
|
I wish we had a "new gray" for this use case, that is, a color that was created for G2. G2 means to use fewer grays overall, but $medium-gray-text does not meet the contrast ratio here. So for the time being and pending other improvements, seems fine to use a variable from the "old" set. But still important to use a variable, so it's easy to search and replace when we do get a time to revisit. 👍 👍 |
|
Updated to use |
jasmussen
approved these changes
May 20, 2020
|
Thank you for the review, @jasmussen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the placeholder text color on the block inserter's search field from #72777c to #6c6f75. The previous color combination is failing AA success criteria with a ratio of 4.11. New color combination achieves passing score 4.57.
How has this been tested?
Tested on Firefox/macOS. Contrast ratio tested with https://webaim.org/resources/contrastchecker/ and https://contrastchecker.com
Screenshots
Previous (#72777c):
Proposed (#6c6f75):
UPDATE:
Using
$dark-gray-400(#606A73) instead. We now have a passing 5.01 contrast ratio.Types of changes
Visual, bug fix.
Checklist: