Refactor block navigation block contents #22487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… do not reuse a shared wrapper
talldan
added
[Type] Code Quality
|
Size Change: +23 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
packages/block-editor/src/components/block-navigation/block-select-button.js
Show resolved
Hide resolved
adamziel
approved these changes
May 21, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a partial step towards fixing #22488.
Refactors some of the Block Navigator internals:
Previously the slot in the block navigator was using a
BlockContentWrappercomponent to achieve the same layout as the button that's used to select blocks. However there were some issues with this code re-use, some attributes were being applied to the wrong elements, notably the props passed byTreeGridCellto manage keyboard navigation and theidused to set thearia-description. These should be passed onto the fill. I don't think there's a good way to achieve code reuse so I've removedBlockContentWrapperand now the slot component and the button component define their own content.The PR also moves some of the components into their own files
How has this been tested?
The block navigator should look and behave like it does in
master.Types of changes
Refactor/Code quality.
Checklist: