-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSE: Add focus mode and top toolbar modes #22537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Enhancement
A suggestion for improvement.
[Feature] Full Site Editing
labels
May 21, 2020
noahtallen
requested review from
youknowriad,
vindl,
epiqueras and
Addison-Stavlo
May 21, 2020 21:12
noahtallen
changed the title
Add/top toolbar mode site editor
FSE: Add top block toolbar mode
May 21, 2020
Size Change: +491 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
epiqueras
reviewed
May 21, 2020
Yes |
6 tasks
noahtallen
changed the title
FSE: Add top block toolbar mode
FSE: Add focus mode and top toolbar modes
May 22, 2020
epiqueras
approved these changes
May 22, 2020
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds top toolbar feature toggle to the site editor. Mostly copied from edit-post. (related: #22535)
While adding this, I noticed that there are a lot of small margin & style differences between edit-site and edit-post. For example, the inserter button isn't a proper square. Additionally, we are missing most of the mobile styles already coded in edit-post. I think we need to share more code between the two since the requirements for both toolbars are nearly identical. Should that kind of refactor go into the
interface
package?How has this been tested?
Locally in edit site
Screenshots
Types of changes
new feature
Checklist: