Link Control: Fix search result focus state border #22553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, avoiding a display bug with the search results.
|
Size Change: +108 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
epiqueras
approved these changes
May 22, 2020
| @@ -135,6 +135,11 @@ $block-editor-link-control-number-of-actions: 1; | |||
| background-color: $light-gray-300; | |||
| } | |||
|
|
|||
| // The added specificity is needed to override. | |||
| &:focus:not(:disabled) { | |||
| box-shadow: 0 0 0 $border-width-focus $theme-color inset; | |||
There was a problem hiding this comment.
Where is the original rule defined?
There was a problem hiding this comment.
There was a problem hiding this comment.
Should it also be inset there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
:focusstate for the search results when adding a link show's a border that is cut off:To fix this, I overrode the default
:focusstyling for the button component to use aninsetbox-shadow: