Navigation Screen: Fetch all menus for display in <select> menu #22591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an unbounded query (per_page=-1) when fetching menus for display in the Navigation Screen. Note that fetchAllMiddleware() will translate this per_page=-1 query into several per_page=100 requests.
noisysocks
added
[Type] Bug
|
Size Change: +12 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22404.
Use an unbounded query (
per_page=-1) when fetching menus for display in the Navigation Screen.Note that
fetchAllMiddleware()will translate thisper_page=-1query into severalper_page=100requests.To test:
for i in {1..20}; do npx wp-env run cli wp menu create "test-menu-$i"; done