Make the panels not collapsible on the experimental navigation screen #22787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta and
youknowriad
as code owners
adamziel
added
[Feature] List View
|
Size Change: +219 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 1, 2020
| @@ -127,6 +127,14 @@ An icon to be shown next to the `PanelBody` title. | |||
| - Type: `String` | |||
| - Required: No | |||
|
|
|||
| ###### collapsible | |||
There was a problem hiding this comment.
Why not just use the "Card" component, isn't it suited for these use-cases?
|
Those panels were made collapsible so that people on a mobile or other small screen aren't forced to scroll through the navigator to get to the block section. Saving and deleting can currently only be done in that section, so I don't think we should remove this until we have a good solution for mobile. |
|
@tellthemachines thank you for the context! How about making only the navigation panel collapsible, and only on mobile? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the panels on the experimental navigation screen non-collapsible.
"A picture is worth a thousand words"
Before:
After:
How has this been tested?
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: