-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the navigator toolbar button on the experimental navigation screen #22792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Block] Navigation
Affects the Navigation Block
[Feature] Navigation Screen
labels
Jun 1, 2020
adamziel
requested review from
ajitbohra,
jorgefilipecosta and
Soean
as code owners
June 1, 2020 11:50
Size Change: +36 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Jun 1, 2020
adamziel
force-pushed
the
fix/remove-navigation-toolbar-option
branch
from
June 2, 2020 12:45
fd1f92e
to
b311b44
Compare
draganescu
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advances #21310
Description
The navigation block's toolbar has a button to bring up the block navigator modal. It makes a lot of sense in the post editor, but less so on the experimental navigation screen the navigator is always visible. This PR hides it on the experimental navigation screen using
blockEditorSettings
- any alternative ideas are highly appreciated!How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: