Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom select control: don't announce external value changes #22815

Merged
merged 8 commits into from
Jun 18, 2020
Merged

Custom select control: don't announce external value changes #22815

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e8909cf
Don't announce external value change
tellthemachines Jun 2, 2020
d8b5ed7
Correct aria attributes
tellthemachines Jun 3, 2020
6c6297e
Improve value equality checking.
tellthemachines Jun 12, 2020
cd87011
Selected item doesn't always exist
tellthemachines Jun 12, 2020
e1c1869
Check if value exists and add default
tellthemachines Jun 12, 2020
1ae478b
Fix initial selection
tellthemachines Jun 15, 2020
914d485
Memoize getSelectOptions instead
tellthemachines Jun 17, 2020
5e980b0
Switch to useMemo
tellthemachines Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/components/src/font-size-picker/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/**
* External dependencies
*/
import memoize from 'memize';

/**
* WordPress dependencies
*/
Expand Down Expand Up @@ -26,7 +31,7 @@ function getSelectValueFromFontSize( fontSizes, value ) {
return DEFAULT_FONT_SIZE;
}

function getSelectOptions( optionsArray, disableCustomFontSizes ) {
const getSelectOptions = memoize( ( optionsArray, disableCustomFontSizes ) => {
optionsArray = [
{ slug: DEFAULT_FONT_SIZE, name: __( 'Default' ) },
...optionsArray,
Expand All @@ -39,7 +44,7 @@ function getSelectOptions( optionsArray, disableCustomFontSizes ) {
name: option.name,
style: { fontSize: option.size },
} ) );
}
} );

export default function FontSizePicker( {
fallbackFontSize,
Expand Down