Image: Consolidate crop ratios #22817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
ajlende
added
[Block] Image
6 tasks
ellatrix
reviewed
Jun 6, 2020
| @@ -85,3 +85,13 @@ | |||
| .richimage-toolbar__control { | |||
| padding: 6px; | |||
| } | |||
|
|
|||
| .richimage__aspect-title { | |||
There was a problem hiding this comment.
Is there no component for this? I see a similar thing in the settings:
There was a problem hiding this comment.
That's where it is! I though I had seen it somewhere, but I couldn't remember where and I couldn't find a component for it, so I assumed I had imagined it. Looks like it's a prop, not a component.
I was going to open another PR to add that to the storybook quick, but would you rather see it under the MenuGroup component or the DropdownMenu component?
ellatrix
reviewed
Jun 6, 2020
ajlende
force-pushed
the
fix/consolidate-crop-ratios
branch
from
03e622c to
a2b67d3
Compare
This matches the terminology from DropdownMenu
ellatrix
approved these changes
Jun 8, 2020
|
Just needs a rebase now :) |
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the portrait/landscape button in favor of a simpler, unified aspect ratio menu with both portrait and landscape ratios in the same menu.
How has this been tested?
Add image block, open crop, view the unified aspect ratio menu.
Screenshots
Types of changes
Fixes #22567
Checklist: