-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Block Navigation Settings Menu keyboard navigation in Navigation Menus page #22885
Merged
adamziel
merged 2 commits into
master
from
fix/block-navigation-settings-menu-keyboard-nav
Jun 8, 2020
Merged
Fix Block Navigation Settings Menu keyboard navigation in Navigation Menus page #22885
adamziel
merged 2 commits into
master
from
fix/block-navigation-settings-menu-keyboard-nav
Jun 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[a11y] Keyboard & Focus
labels
Jun 4, 2020
talldan
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
jorgefilipecosta and
youknowriad
as code owners
June 4, 2020 08:20
talldan
changed the title
Fix block navigation settings menu keyboard navigation
Fix block navigation settings menu keyboard navigation in Navigation Menus page
Jun 4, 2020
talldan
changed the title
Fix block navigation settings menu keyboard navigation in Navigation Menus page
Fix Block Navigation Settings Menu keyboard navigation in Navigation Menus page
Jun 4, 2020
3 tasks
Size Change: +60 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
adamziel
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@talldan works as expected, thank you!
priethor
added
the
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
label
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some keyboard accessibility issues had crept into the Block Navigation in its form on the Navigation Screen.
This PR fixes an issue with the Block Navigation's Block Settings menu. Roving tab index and arrow key navigation should now work again with this component.
It also makes the relationship between
TreeGridCell
and the various components used in theBlockNavigation
clearer by explicitly declaring the forwarded props individually rather than by spreading them as...props
.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: