Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix am / pm i18n's bug #22963

Merged
merged 5 commits into from
Jun 20, 2020
Merged

Fix am / pm i18n's bug #22963

merged 5 commits into from
Jun 20, 2020

Conversation

miminari
Copy link
Member

@miminari miminari commented Jun 6, 2020 •
edited by ocean90
Loading

Description

Fixes #22924
I changed the state am value to just string 'AM' and 'PM' for i18n.

How has this been tested?

  1. Make the setting of time to g:i A, and the language to Japanese.
  2. Create a new post.
  3. Document > Publish
  4. You can change AM='午前', PM='午後' and that's current color.

Screenshots

Kapture 2020-06-06 at 16 12 23

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@Soean Soean added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Jun 6, 2020
@torounit
Copy link
Member

torounit commented Jun 6, 2020

@miminari

It's helpful.

https://github.com/moment/moment/blob/a0f3c74374b638b769d9ab1ae54ba5266ef0976f/moment.js#L1996-L2002

@miminari
Copy link
Member Author

miminari commented Jun 6, 2020 •
edited
Loading

Thanks, @torounit .
I changed the way, the 'am' state value to just string 'AM' or 'PM', not __() value.

@ocean90 ocean90 added the [Package] Components /packages/components label Jun 6, 2020
torounit
torounit requested changes Jun 7, 2020
View reviewed changes
packages/components/src/date-time/time.js Outdated Show resolved Hide resolved
packages/components/src/date-time/time.js Outdated Show resolved Hide resolved
@torounit
Copy link
Member

torounit commented Jun 9, 2020

@miminari
Looks good!

@miminari
Copy link
Member Author

miminari commented Jun 9, 2020

@torounit Thank you for your review!

@torounit torounit requested a review from swissspidy June 10, 2020 14:16
@torounit torounit added the [Type] Bug An existing feature does not function as intended label Jun 17, 2020
@youknowriad youknowriad merged commit 5e0b80a into WordPress:master Jun 20, 2020
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 20, 2020
@torounit torounit deleted the fix/am-pm-i18n branch June 20, 2020 09:05
This was referenced Jun 24, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torounit torounit torounit approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@youknowriad youknowriad Awaiting requested review from youknowriad

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 8.4
Development

Successfully merging this pull request may close these issues.

AM/PM button on calendar does not activate in Japanese environment
5 participants
@miminari @torounit @youknowriad @ocean90 @Soean