[Navigation screen] Separate block navigator focus from the editor focus #22996
Conversation
|
Size Change: +368 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
adamziel
requested review from
ajitbohra,
chrisvanpatten,
mkaz and
youknowriad
as code owners
adamziel
added
[Feature] List View
|
This PR breaks some tests ATM, I'd like to get some initial feedback on direction before debugging them. |
|
Hi @adamziel 👋 This feels good to me. Focus placement is more obvious to me now. |
|
I agree with @enriquesanchez that is feels a lot more reliable and obvious where focus will end up. 👍 I'm not sure what to do about the selected block being highlighted, potentially it's not needed any more, although at the same time it might be useful for a user looking to jump between the normal editor and the block navigation. Though it could also be confusing. I notice we're showing the movers and settings menu for the selected block, which is probably not needed now that you can't select the block in the block navigation. I think they should be shown for the focused and hovered blocks only. I still think an option to jump to the actual block from the block navigation might be useful, I wonder if we might want to explore a 'Go To ...' option in the settings menu as part of a separate issue? |
|
I just want to +1 the "Go to..." idea!
|
I was actually confused and did not know that the block icon was meant to take you to the nav block. I don't think that's obvious, we certainly don't have that same interaction anywhere else, do we?
+1 to this idea, but I'm finding it hard to come up with the right text for this. In addition to Andrei's suggestions, I'll add "Go to block" |
adamziel
force-pushed
the
fix/navigator-focus
branch
from
c5e98ba to
fa5b9b0
Compare
|
All good notes! I removed the dark CSS when an item is "selected" and added a "Go to" action (naming TBD):
The next step here for me is to fix unit/e2e tests and rigorously user-test the entire PR. |
|
I love that Go to option! Feels pretty neat :)
|
adamziel
force-pushed
the
fix/navigator-focus
branch
from
fa5b9b0 to
00a0b61
Compare
|
@draganescu good catch! I just fixed the non-responding "Go to block" button. I am unable to reproduce the other issue (non-responding navigator item). Let's get these tests green and see if it's still happening. |
|
Alright, this one seems to be ready for re-review! |
There was a problem hiding this comment.
I tested this locally and it works to keep the selection in the navigator for the navigation screen while not affecting how selection works in the post editor.
There is a spinoff issue #23269 that should improve how returning the focus to the block list works, as right now a nested block doesn't get it's editable area focused.
adamziel
force-pushed
the
fix/navigator-focus
branch
from
05d9ab8 to
70d64c9
Compare
Description
Closes #22705
This PR is an attempt to separates the block navigator selection/focus from the editor area. Once applied, all actions performed in the navigator will only affect selection/focus within the navigator instead of trying to synchronize with the editor area:
CC @enriquesanchez and @karmatosed for sanity check
Editing the caption is not implemented yet.
Open questions:
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: