Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the theme colors to rely on CSS variables #23048

Merged
merged 12 commits into from
Jun 16, 2020
Merged

Update the theme colors to rely on CSS variables #23048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f5a2149
Update the theme colors to rely on CSS variables
youknowriad Jun 10, 2020
9708d09
rename CSS variables
youknowriad Jun 11, 2020
8255a78
Add comment to explain the duplication
youknowriad Jun 11, 2020
b67a5f9
Remove useless PostCSS plugin
youknowriad Jun 12, 2020
d4e6b03
Fix the production build
youknowriad Jun 12, 2020
ff03248
Update the CSS variables setup
youknowriad Jun 15, 2020
0aa5a11
restore removed file
youknowriad Jun 15, 2020
2b1506b
Fix admin scheme mixin
youknowriad Jun 15, 2020
3e1bad6
Fix checkbox.
Jun 16, 2020
197900e
Retire toggle color.
Jun 16, 2020
43d41f4
Retire the 2nd color variable.
Jun 16, 2020
190b041
Update colors.
Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/packages/build-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ const babel = require( '@babel/core' );
const makeDir = require( 'make-dir' );
const sass = require( 'node-sass' );
const postcss = require( 'postcss' );

/**
* Internal dependencies
*/
Expand Down
219 changes: 118 additions & 101 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
"nock": "12.0.3",
"node-sass": "4.13.1",
"node-watch": "0.6.0",
"postcss": "7.0.13",
"postcss": "7.0.32",
"postcss-loader": "3.0.0",
"prettier": "npm:[email protected]",
"progress": "2.0.3",
Expand Down
4 changes: 4 additions & 0 deletions packages/base-styles/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

## Breaking Changes

- Remove the AdminColorThemes JavaScript variables.

## 1.2.0 (2020-01-13)

### Bug Fix
Expand Down
9 changes: 0 additions & 9 deletions packages/base-styles/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,4 @@ To make that work with [`sass`](https://www.npmjs.com/package/sass) or [`node-sa
}
```

### PostCSS color schemes

To use color schemes with [`@wordpress/postcss-themes`](https://www.npmjs.com/package/@wordpress/postcss-themes), import them like so:

```js
const { adminColorSchemes } = require( '@wordpress/base-styles' );
const wpPostcss = require( '@wordpress/postcss-themes' )( adminColorSchemes )
```

<br/><br/><p align="center"><img src="https://s.w.org/style/images/codeispoetry.png?1" alt="Code is Poetry." /></p>
2 changes: 0 additions & 2 deletions packages/base-styles/_colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ $medium-gray-text: #757575; // Meets 4.6:1 text contrast.
$light-gray-ui: #949494; // Meets 3:1 UI contrast.
$light-gray-secondary: #ccc;
$light-gray-tertiary: #e7e8e9;
$theme-color: theme(button);
$blue-medium-focus: theme(button);
$blue-medium-focus-dark: $white;

// Dark opacities, for use with light themes.
Expand Down
Loading