-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichText: rewrite with hooks #23132
Merged
Merged
RichText: rewrite with hooks #23132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -1.02 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
[Feature] Rich Text
Related to the Rich Text component that allows developers to render a contenteditable
[Package] Rich text
/packages/rich-text
[Type] Code Quality
Issues or PRs that relate to code quality
labels
Jun 14, 2020
ellatrix
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
June 14, 2020 16:55
I think this lacks a lot of inline docs/comments, it's very hard to follow these useEffect calls. |
youknowriad
added a commit
that referenced
this pull request
Jun 16, 2020
This reverts commit f15b91c.
This was referenced Jun 24, 2020
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Rich Text
Related to the Rich Text component that allows developers to render a contenteditable
[Package] Rich text
/packages/rich-text
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A little weekend project.
Also fixes a problem where the caret position would not be correctly restored when undoing across blocks.
How has this been tested?
Screenshots
Types of changes
Checklist: