Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor column block to use hooks #23143

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

oxyc
Copy link
Member

@oxyc oxyc commented Jun 14, 2020

Description

How has this been tested?

Tested adding a a columns block, setting a vertical alignment then changing the vertical alignment of an inner column and checking that the parent Columns block alignment was reset.

Screenshots

Types of changes

Code quality

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@oxyc oxyc requested review from ajitbohra, Soean and talldan as code owners June 14, 2020 17:09
@ZebulanStanphill ZebulanStanphill added [Block] Columns Affects the Columns Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality labels Jun 14, 2020
Copy link
Member

@ZebulanStanphill ZebulanStanphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to go!

@ZebulanStanphill ZebulanStanphill merged commit c663493 into WordPress:master Jun 16, 2020
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 16, 2020
This was referenced Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants