Polish: Unify subheadings style. #23192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
jasmussen
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
youknowriad
as code owners
6 tasks
gziolo
approved these changes
Jun 16, 2020
|
Aaawesome, thank you! |
|
Size Change: +33 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overlaps ever so slightly with #23028, but it uses the same CSS so the overlap should disappear in whatever PR needs to do the rebase first.
It does one thing primarily, which is to unify all subheadings to use the same style. The purpose, outside of consistency, is to better differentiate what is a subheading, and what is an actionable submenu item, while still maintaining contrast.
Before:
After:
Before:
After:
Before:
After:
All of these are gray. But they are a darker gray that has better contrast. They are not blue, because although it makes for a nice bit of admin theming, it makes them appear actionable, and it clashes with the hover color of menu items. Notably that meant the following is also changed:
After:
It does one final thing, makes the separators in primary menus dark to match the border. Before:
After: